Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Integers representing boolean truth values should be converted to bool #82

Closed
2 tasks done
thnkslprpt opened this issue May 2, 2023 · 0 comments · Fixed by #83
Closed
2 tasks done

Integers representing boolean truth values should be converted to bool #82

thnkslprpt opened this issue May 2, 2023 · 0 comments · Fixed by #83
Labels
enhancement

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
There are a few variables in CS represented by integers when they only ever hold boolean true/false values.

Code snips

CS/fsw/inc/cs_tbldefs.h

Line 84 in bd4dd1c

uint16 ComputedYet; /**< \brief Have we computed an Integrity value yet */

CS/fsw/inc/cs_msg.h

Lines 51 to 52 in bd4dd1c

uint8 RecomputeInProgress; /**< \brief CS "Recompute In Progress" flag */
uint8 OneShotInProgress; /**< \brief CS "OneShot In Progress" flag */

Expected behavior
Integers representing boolean truth values should be converted bool - this makes the intent clearer and improves maintainability.

Reporter Info
Avi Weiss @thnkslprpt
thnkslprpt added a commit to thnkslprpt/CS that referenced this issue May 2, 2023
@thnkslprpt
Fix nasa#82, Convert integers holding boolean truth values to bool
3d8269d
@thnkslprpt thnkslprpt mentioned this issue May 2, 2023
Merged
2 tasks
thnkslprpt added a commit to thnkslprpt/CS that referenced this issue May 4, 2023
@thnkslprpt
Fix nasa#82, Convert integers holding boolean truth values to bool
f28181d
thnkslprpt added a commit to thnkslprpt/CS that referenced this issue May 4, 2023
@thnkslprpt
Fix nasa#82, Convert integers holding boolean truth values to bool
aa585b7
thnkslprpt added a commit to thnkslprpt/CS that referenced this issue Sep 30, 2023
@thnkslprpt
Fix nasa#82, Convert integers holding boolean truth values to bool
cabac30
dzbaker added a commit that referenced this issue Feb 8, 2024
@dzbaker
Merge pull request #83 from thnkslprpt/fix-82-convert-boolean-integer…
f29e12d 
…s-to-bool

Fix #82, Convert integers holding boolean truth values to `bool`
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #82, Convert integers holding boolean truth values to bool thnkslprpt/CS
2 participants
@thnkslprpt @chillfig