-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Inconsistent Event ID naming #59
Labels
Comments
thnkslprpt
added a commit
to thnkslprpt/FM
that referenced
this issue
Oct 21, 2022
2 tasks
thnkslprpt
added a commit
to thnkslprpt/FM
that referenced
this issue
Mar 12, 2023
thnkslprpt
added a commit
to thnkslprpt/FM
that referenced
this issue
Mar 12, 2023
thnkslprpt
added a commit
to thnkslprpt/FM
that referenced
this issue
Mar 30, 2023
thnkslprpt
added a commit
to thnkslprpt/FM
that referenced
this issue
Mar 30, 2023
thnkslprpt
added a commit
to thnkslprpt/FM
that referenced
this issue
Nov 1, 2023
dzbaker
added a commit
that referenced
this issue
Jul 15, 2024
…id-names Fix #59, Apply consistent Event ID names to common events
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Checklist
Describe the bug
Copy of nasa/cFE#2175
After finding that there were 9 different Event IDs to indicate the same thing (Invalid Message ID) in nasa/CF#262, I scrubbed the other common commands (e.g. Task Initialisation [INIT], NOOP, Reset Counters etc.) and found the same issue there - almost every component/app had their own variation of the Event ID name for the exact same event.
Expected behavior
Apply consistent Event ID names to the events which are common to all/most components and apps.
Code snips
Invalid Message ID:
CFE_EVS_ERR_MSGID_EID
CFE_SB_BAD_MSGID_EID
CFE_TIME_ID_ERR_EID
CS_MID_ERR_EID
TO_LAB_MSGID_ERR_EID
SAMPLE_APP_INVALID_MSGID_ERR_EID
BP_INVALID_MID_ERR_EID
SCH_MD_ERR_EID
CI_LAB_COMMAND_ERR_EID
Initialization:
CFE_TIME_INIT_EID
CFE_TBL_INIT_INF_EID
CFE_EVS_STARTUP_EID
CF_EID_INF_INIT
BP_INIT_APP_INFO_EID
SCH_INITSTATS_INF_EID
CI_LAB_STARTUP_INF_EID
NOOP:
CFE_TIME_NOOP_EID
CFE_TBL_NOOP_INF_EID
CFE_SB_CMD0_RCVD_EID
CF_EID_INF_CMD_NOOP
FM_NOOP_CMD_EID
CI_LAB_COMMANDNOP_INF_EID
Reset Counters:
CFE_TIME_RESET_EID
CFE_TBL_RESET_INF_EID
CFE_EVS_RSTCNT_EID
CFE_SB_CMD1_RCVD_EID
CF_EID_INF_CMD_RESET
SC_RESET_DEB_EID
HS_RESET_DBG_EID
FM_RESET_CMD_EID
HK_RESET_CNTRS_CMD_EID
MD_RESET_CNTRS_DBG_EID
CI_LAB_COMMANDRST_INF_EID
etc.
Reporter Info
Avi Weiss @thnkslprpt
The text was updated successfully, but these errors were encountered: