Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Replace the "free space" table with a more general disk monitoring table, which can have entries for volume free space (which is what was there) as well as an estimate of directory usage.
Table and TLM was renamed accordingly. This changes the definition of the TLM report to include the extra info, so it requires a ground system update.
Fixes #51
Testing performed
Build and run FM in CFE, issue "monitor" command (16) and confirm correct/expected TLM is sent
Run all tests, confirm 100% coverage
Expected behavior changes
The "free space" command is replaced with a more general "monitor" command that allows for multiple types/flavors of monitoring. The VOLUME_FREE_SPACE type implements the same logic as the original free space table/command, and the newly added DIRECTORY_ESTIMATE type implements the request in #51.
System(s) tested on
Ubuntu 22.04
Additional context
This is effectively replacing the old free space TLM packet (FM_FREE_SPACE_TLM_MID) with a monitor report TLM that is more general. Notably, it contains a type indicator, and it can report either space used or space free depending on type.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.