Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #3, change HK_INPUTMID_SUBSCRIBED to 1 #21

Closed
wants to merge 1 commit into from

Conversation

havencarlson
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
Fix #3, change macro HK_INPUTMID_SUBSCRIBED from 0xFF to 1

Testing performed
Unit testing

Expected behavior changes
No impact to behavior

System(s) tested on

  • OS: Ubuntu 18.04

Contributor Info - All information REQUIRED for consideration of pull request
Haven Carlson - NASA

@skliper
Copy link
Contributor

skliper commented Aug 18, 2022

Recommend closing, original issue lacks justification. Why change just the value? If it was true/false the unique defines could go away which would make more sense to me... but just a value change doesn't simplify anything.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change HK_INPUTMID_SUBSCRIBED to 1
2 participants