Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Change HK_INPUTMID_SUBSCRIBED to 1 #3

Closed
skliper opened this issue Apr 22, 2022 · 1 comment
Closed

Change HK_INPUTMID_SUBSCRIBED to 1 #3

skliper opened this issue Apr 22, 2022 · 1 comment
Assignees
@havencarlson
Labels
wontfix

Comments

@skliper
Copy link
Contributor

skliper commented Apr 22, 2022

In hk_utils.h suggest setting HK_INPUTMID_SUBSCRIBED to 1 instead of 0xFF.

Finding in code review.

Imported from GSFCCFS-987
@skliper skliper changed the title HK Macro Change Change HK_INPUTMID_SUBSCRIBED to 1 Jul 29, 2022
@havencarlson havencarlson self-assigned this Aug 16, 2022
havencarlson added a commit to havencarlson/HK that referenced this issue Aug 16, 2022
@havencarlson
Fix nasa#3, change HK_INPUTMID_SUBSCRIBED to 1
2e93e37
@havencarlson havencarlson mentioned this issue Aug 17, 2022
Closed
2 tasks
@skliper
Copy link
Contributor Author

skliper commented Aug 18, 2022

Issue lacks justification. Not clear what the benefit of this change would be. If anyone has any background feel free to add and reopen.

@skliper skliper closed this as completed Aug 18, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@havencarlson havencarlson

Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3, change HK_INPUTMID_SUBSCRIBED to 1 havencarlson/HK
2 participants
@skliper @havencarlson