Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

HS missing requirements for SetUtilDiagCmd, SetUtilParamsCmd, and UtilDiagReport (all hs_custom.c) #41

Closed
3 tasks done
skliper opened this issue Aug 5, 2022 · 0 comments · Fixed by #42
Closed
3 tasks done
Assignees
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Aug 5, 2022

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
Although these are in the custom section and may need adjustment depending on resolution of the hogging task related issues, the current implementation is missing associated requirements for HS_REPORT_DIAG_CC, HS_SET_UTIL_PARAMS_CC, HS_SET_UTIL_DIAG_CC:

#define HS_REPORT_DIAG_CC 12

#define HS_SET_UTIL_PARAMS_CC 13

#define HS_SET_UTIL_DIAG_CC 14

Describe the solution you'd like
All commands should have associated requirements, add.

Describe alternatives you've considered
None in the short term. Longer term may update behavior based on:

Additional context
Really should be at minimum in the draco-rc2 requirements documents (as well as many historical versions).

Requester Info
Jacob Hageman - NASA/GSFC

Ping for awareness: @ArielSAdamsNASA

@skliper skliper added this to the Draco milestone Aug 5, 2022
@skliper skliper self-assigned this Aug 9, 2022
dzbaker added a commit that referenced this issue Aug 10, 2022
Fix #41, Add utility command requirements for existing implementation
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants