Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CFE_ES_RegisterCDSEx stub mismatch #1010

Closed
skliper opened this issue Nov 12, 2020 · 0 comments · Fixed by #1011 or #1008
Closed

CFE_ES_RegisterCDSEx stub mismatch #1010

skliper opened this issue Nov 12, 2020 · 0 comments · Fixed by #1011 or #1008
Labels
bug Priority: Mission Feature or bug related to stakeholder needs
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Nov 12, 2020

Describe the bug
Mismatch in CFE_ES_RegisterCDSEx implementation and stub.

To Reproduce
Inspection

Expected behavior
Matching stub.

Code snips

cFE/fsw/cfe-core/src/es/cfe_es_cds.c

Line 308 in 9804b59

int32 CFE_ES_RegisterCDSEx(CFE_ES_CDSHandle_t *HandlePtr, CFE_ES_CDS_Offset_t UserBlockSize, const char *Name, bool CriticalTbl)

cFE/fsw/cfe-core/ut-stubs/ut_es_stubs.c

Lines 972 to 975 in 9804b59

int32 CFE_ES_RegisterCDSEx(CFE_ES_CDSHandle_t *HandlePtr,
int32 BlockSize,
const char *Name,
bool CriticalTbl)

System observed on:
NA

Additional context
Looks like it was introduced in daf6c04, part of fix #56

Reporter Info
Jacob Hageman - NASA/GSFC (from stakeholder email)
@skliper skliper added the bug label Nov 12, 2020
@skliper skliper added this to the 7.0.0 milestone Nov 12, 2020
@skliper skliper added the Priority: Mission Feature or bug related to stakeholder needs label Nov 12, 2020
skliper added a commit to skliper/cFE that referenced this issue Nov 12, 2020
@skliper
Fix nasa#1010, CFE_ES_RegisterCDSEx stub update
f3501e0
@skliper skliper mentioned this issue Nov 12, 2020
Merged
skliper added a commit to skliper/cFE that referenced this issue Nov 12, 2020
@skliper
Fix nasa#1010, CFE_ES_RegisterCDSEx stub update
53d0422
This was referenced Nov 12, 2020
Closed
Merged
astrogeco added a commit that referenced this issue Nov 13, 2020
@astrogeco
Merge pull request #1011 from skliper/fix1010-cfe_es_registercdsex-stub
d7b5839 
Fix #1010, CFE_ES_RegisterCDSEx stub update
@astrogeco astrogeco mentioned this issue Nov 13, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Priority: Mission Feature or bug related to stakeholder needs
Projects
None yet
Milestone
Caelum
1 participant
@skliper