Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace hardcoded message limits in TIME services #1537

Closed
skliper opened this issue May 17, 2021 · 0 comments · Fixed by #2002 or #2001
Closed

Replace hardcoded message limits in TIME services #1537

skliper opened this issue May 17, 2021 · 0 comments · Fixed by #2002 or #2001

Comments

@skliper
Copy link
Contributor

skliper commented May 17, 2021

Is your feature request related to a problem? Please describe.
Hard coded as 4, although if there's 2 messages in the pipe that'd be an issue...

Status = CFE_SB_SubscribeLocal(CFE_SB_ValueToMsgId(CFE_TIME_TONE_CMD_MID), CFE_TIME_Global.CmdPipe, 4);

Status = CFE_SB_SubscribeLocal(CFE_SB_ValueToMsgId(CFE_TIME_DATA_CMD_MID), CFE_TIME_Global.CmdPipe, 4);

Status = CFE_SB_SubscribeLocal(CFE_SB_ValueToMsgId(CFE_TIME_1HZ_CMD_MID), CFE_TIME_Global.CmdPipe, 4);

Describe the solution you'd like
The default subscriptions just use CFE_PLATFORM_SB_DEFAULT_MSG_LIMIT so could just use it to keep subscriptions the same, even though 2 would be bad it's likely handled by the related verification logic.

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC

zachar1a added a commit to zachar1a/cFE that referenced this issue Oct 20, 2021
astrogeco pushed a commit to zachar1a/cFE that referenced this issue Nov 10, 2021
- Uses CFE_PLATFORM_SB_DEFAULT_MSG_LIMIT
astrogeco added a commit to astrogeco/cFE that referenced this issue Nov 10, 2021
…d_msg_limits_in_TIME_services

Fix nasa#1537, replacing hardcoded message limit in TIME services
@skliper skliper added this to the Draco milestone Mar 28, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
1 participant