Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CFE_MSG_GetTypeFromMsgId not handling all invalid inputs #1757

Closed
zanzaben opened this issue Aug 3, 2021 · 0 comments · Fixed by #1758 or #1759
Closed

CFE_MSG_GetTypeFromMsgId not handling all invalid inputs #1757

zanzaben opened this issue Aug 3, 2021 · 0 comments · Fixed by #1758 or #1759
Assignees
@zanzaben
Labels
bug
Milestone
Caelum

Comments

@zanzaben
Copy link
Contributor

zanzaben commented Aug 3, 2021

Is your feature request related to a problem? Please describe.
CFE_MSG_GetTypeFromMsgId calls CFE_MSG_SetMsgId and CFE_MSG_GetType but ignores those return calls. They can return fail status codes so CFE_MSG_GetTypeFromMsgId should handle that.

Describe the solution you'd like
CFE_MSG_GetTypeFromMsgId should check for failing status codes and return them if they happen.

Requester Info
Alex Campbell GSFC
@skliper skliper added the bug label Aug 4, 2021
@skliper skliper added this to the 7.0.0 milestone Aug 4, 2021
@zanzaben zanzaben self-assigned this Aug 4, 2021
zanzaben added a commit to zanzaben/cFE that referenced this issue Aug 4, 2021
@zanzaben
Fix nasa#1757, Handle fail status from internal functions of TestGetT…
7fb0825 
…ypeFromMsgId
zanzaben added a commit to zanzaben/cFE that referenced this issue Aug 4, 2021
@zanzaben
Fix nasa#1757, Handle fail status from internal functions of CFE_MSG_…
0b45436 
…GetTypeFromMsgId
@zanzaben zanzaben mentioned this issue Aug 4, 2021
Merged
zanzaben added a commit to zanzaben/cFE that referenced this issue Aug 4, 2021
@zanzaben
Fix nasa#1757, Handle fail status in GetTypeFromMsgId
6cf2e2f
astrogeco added a commit that referenced this issue Aug 4, 2021
@astrogeco
Merge pull request #1758 from zanzaben/fix1757_handle_fail_codes_GetT…
a434d6c 
…ypeFromMsgId

Fix #1757, Handle fail status from internal functions of CFE_MSG_GetT…
@astrogeco astrogeco mentioned this issue Aug 4, 2021
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@zanzaben zanzaben

Labels
bug
Projects
None yet
Milestone
Caelum
2 participants
@zanzaben @skliper