Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update wrong comment regarding the value of CFE_SB_INVALID_MSG_ID #2116

Closed
pepepr08 opened this issue Jun 9, 2022 · 2 comments · Fixed by #2359 or #2586
Closed

Update wrong comment regarding the value of CFE_SB_INVALID_MSG_ID #2116

pepepr08 opened this issue Jun 9, 2022 · 2 comments · Fixed by #2359 or #2586
Labels
docs This change only affects documentation.

Comments

@pepepr08
Copy link
Contributor

pepepr08 commented Jun 9, 2022

Describe the bug
CFE_SB_INVALID_MSG_ID value is no longer the maximum representable number of type CFE_SB_MsgId_t. Comment needs to be updated.

Code snips
Link to lines of code

Reporter Info
Jose F. Martinez Pedraza / GSFC 582

@skliper skliper added the docs This change only affects documentation. label Jun 9, 2022
dzbaker added a commit that referenced this issue Jul 1, 2024
…n-for-CFE-PLATFORM-SB-HIGHEST-VALID-MSGID

Fix #2116, Update comment re. limits of CFE_PLATFORM_SB_HIGHEST_VALID_MSGID
@dzbaker dzbaker closed this as completed in c92df5f Jul 2, 2024
@pepepr08
Copy link
Contributor Author

Re-oppening since issue is only partially solved. When I created the issue, I could have been more specific about the places where it needed to be fixed. The comment was fixed in default_cfe_sb_internal_cfg.h, but it also needs to be fixed in example_platform_config.h It still says CFE_PLATFORM_SB_HIGHEST_VALID_MSGID lower limit is 1, up to CFE_SB_INVALID_MSG_ID - 1. and CFE_SB_INVALID_MSG_ID seems to be set to 0. https://github.com/nasa/cFE/blob/d0e9564b09ead61c60a8af235431a69b9aef85c0/cmake/sample_defs/example_platform_cfg.h#L1149C10-L1149C96

@pepepr08 pepepr08 reopened this Jul 22, 2024
@thnkslprpt
Copy link
Contributor

Re-oppening since issue is only partially solved...

Good point. Thanks.

dzbaker added a commit that referenced this issue Aug 2, 2024
…ighest-valid-msgid

Fix #2116, Update comment re. limit of CFE_PLATFORM_SB_HIGHEST_VALID_MSGID
@dzbaker dzbaker closed this as completed in 171276e Aug 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
docs This change only affects documentation.
Projects
None yet
3 participants