Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

wrong closing parenthesis in CFE_MSG_CMD_HDR_INIT macro #2317

Open
mgbark23 opened this issue May 1, 2023 · 1 comment · May be fixed by #2318
Open

wrong closing parenthesis in CFE_MSG_CMD_HDR_INIT macro #2317

mgbark23 opened this issue May 1, 2023 · 1 comment · May be fixed by #2318
Labels
enhancement

Comments

@mgbark23
Copy link

mgbark23 commented May 1, 2023 •
edited
Loading

The CFE_MSG_CMD_HDR_INIT macro's parentheses are not properly balanced.

The CFE_MSG_CMD_HDR_INIT macro contains a ')' instead of a '}' in line 70 as of Latest commit [f9112b4] on Jun 7, 2022
File: nasa/cFE/modules/msg/option_inc/default_cfe_msg_hdr_priext.h

Simple inspection shows the problem.

Opening and closing parentheses should be balanced.

line 70: .SystemId = {0, 0) \

Matthias Bark, Boeing
@thnkslprpt
Copy link
Contributor

thnkslprpt commented May 2, 2023 •
edited
Loading

There is also an unbalanced (extra) round bracket/parenthesis:

Screenshot 2023-05-02 11 19 15

thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue May 2, 2023
@thnkslprpt
Fix nasa#2317, Correct unbalanced brackets in CFE_MSG_CMD_HDR_INIT …
547ad5a 
…macro
@thnkslprpt thnkslprpt linked a pull request May 2, 2023 that will close this issue
Open
2 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2317, Correct unbalanced brackets in CFE_MSG_CMD_HDR_INIT macro thnkslprpt/cFE
3 participants
@thnkslprpt @chillfig @mgbark23