-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add unsubscribe test case to cover #862 #873
Comments
Looks like current tests hits it ... lcov report shows that lines 1102-1110 were covered one time. But I will assume you mean that you'd like an explicit test. |
Note `Test_Unsubscribe_NoMatch) doesn't actually unsubscribe from MsgId or SB_UT_TLM_MID1, so it's not checking the unsubscribe followed by unsubscribe case. The test modifies the PipeId for the MsgId description such that it won't unsubscribe. I had to dig a bit since the test is light on comments as to the "why"... cFE/fsw/cfe-core/unit-test/sb_UT.c Lines 2520 to 2544 in be1a23a
|
Fix #873, Add test for SB subscribe/unusubscribe/unsubscribe
Is your feature request related to a problem? Please describe.
#862 looks like it could have resulted in a seg fault, fixed in #865
Unsubscribe after no subscriptions are left...
Describe the solution you'd like
Add test case.
Describe alternatives you've considered
None. Should add test to confirm code works.
Additional context
#862 #865
Requester Info
Jacob Hageman - NASA/GSFC
@CDKnightNASA
The text was updated successfully, but these errors were encountered: