Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #795, Remove legacy time header format support #801

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Aug 12, 2020

Describe the contribution
Fix #795
Fix #92
Collapses options down to just 32 bit second, 16 bit subsecond, always big endian. Removes old defines, and errors out if the configuration is set to a format that was removed.

Testing performed
Built and make test with SIMULATION=native ENABLE_UNIT_TESTS=true, passes test.

Expected behavior changes
Time in header always big endian.

System(s) tested on

Additional context
#726

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added enhancement CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Aug 12, 2020
@skliper skliper added this to the 7.0.0 milestone Aug 12, 2020
@skliper skliper force-pushed the fix795-time-format branch from 55d0764 to c039fb4 Compare August 14, 2020 15:00
@astrogeco
Copy link
Contributor

CCB 2020-08-19 APPROVED, provide example for override. See idea in #726

@yammajamma yammajamma added CCB:Approved Indicates code review and approval by community CCB IC-20200819 labels Aug 20, 2020
@skliper skliper force-pushed the fix795-time-format branch from c039fb4 to 1582beb Compare August 20, 2020 13:51
@skliper
Copy link
Contributor Author

skliper commented Aug 20, 2020

Rebased on integration-candidate

@yammajamma yammajamma changed the base branch from main to integration-candidate August 20, 2020 13:52
@yammajamma yammajamma merged commit f8c7754 into nasa:integration-candidate Aug 20, 2020
@yammajamma yammajamma removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Aug 20, 2020
astrogeco added a commit that referenced this pull request Aug 25, 2020
HOTFIX for #801 on IC-20200819: Deprecated time format verify logic fix
@skliper skliper deleted the fix795-time-format branch February 1, 2021 22:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CCB:Approved Indicates code review and approval by community CCB enhancement
Projects
None yet
3 participants