Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #863, Add debug message from SendEvents #864

Merged

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Sep 4, 2020

Describe the contribution
Fix #863 - added debug message

Testing performed
Built and ran test (used to debug failure in nasa/cFS#136)

Expected behavior changes
Now prints EID and Spec when stub APIs are called in debug mode.

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: main bundle + this commit

Additional context
None.

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added enhancement CCB:FastTrack CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Sep 4, 2020
@skliper skliper added this to the 7.0.0 milestone Sep 4, 2020
Copy link
Contributor

@CDKnightNASA CDKnightNASA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to do something like:

#define CFE_EVS_SendEvent(EID, TYPE, SPEC, ...) CFE_EVS_SendEvent_Impl(EID, #EID, __func__, __LINE__, TYPE, SPEC, ...)

int32 CFE_EVS_SendEvent_Impl(uint16 EventID, const char *EventIDName, const char *FuncName, int LineNum, uint16 EventType, const char *Spec, ...) { 
...
UtDebug("CFE_EVS_SendEvent: %u (%s) - %s (%s:%d)", EventID, EventIDName, Spec, FuncName, LineNum);
...}

apologies for the broken vararg macro blah blah. :D

@astrogeco
Copy link
Contributor

CCB 2020-09-09 APPROVED, @CDKnightNASA can you open issue for your suggestion above?

@yammajamma yammajamma changed the base branch from main to integration-candidate September 10, 2020 15:18
@yammajamma yammajamma added IC-20200909 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Sep 10, 2020
@yammajamma yammajamma merged commit 5c296a8 into nasa:integration-candidate Sep 10, 2020
@skliper skliper deleted the fix863-debugmsg-events branch February 1, 2021 22:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add debug messages from CFE_EVS_SendEvent stubs
4 participants