Fix #870, generic counter table management #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
added
CCB:Ready
Apply the appid/taskid pattern to Generic Counter resources. No real logic change - just putting the repeated logic into inline functions.
jphickey
force-pushed
the
fix-870-gencounter-tbl-mgmt
branch
from
193d9bb to
5ebd865
Compare
|
Ping @astrogeco and @yammajamma - can add this to CCB agenda too |
|
CCB 2020-09-09 APPROVED, in the future should move to changing IDs to not be zero based and non-repeating to protect against using the wrong counter. Link thread safety issues and open issues to visualize, track, and understand what needs to be fixed. |
yammajamma
added
IC-20200909
and removed
CCB:Ready
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Apply the appid/taskid pattern to Generic Counter resources.
Testing performed
Unit tests
Build and sanity test CFE.
Expected behavior changes
No real logic change - just putting the repeated logic into inline functions.
However, This does add a
CFE_ES_LockSharedData()wrapper around counter ID allocation, deletion, and lookup to avoid a possible race condition here. This was likely a bug, but never noticed perhaps because these aren't a heavily used feature.System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.