Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Integration Candidate 2020-11-10 #60

Merged
merged 5 commits into from
Nov 16, 2020
Merged

Integration Candidate 2020-11-10 #60

merged 5 commits into from
Nov 16, 2020

Conversation

astrogeco
Copy link
Contributor

@astrogeco astrogeco commented Nov 12, 2020

Describe the contribution
Fix #57, Use MSG APIs
Fix #59, Remove non-portable OS_PACK

Testing performed
Bundle CI on astrogeco: https://travis-ci.com/github/astrogeco/cFS/builds/201769124

Expected behavior changes

PR #58 - Replaces deprecated SB API's with MSG

PR #61 - No behavior impact, removes undesirable pattern use of OS_PACK

System(s) tested on
Ubuntu CI

Additional context
Part of nasa/cFS#156

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
@skliper

@jphickey
Copy link
Contributor

Discovered a possible issue on my system with the latest change here - I pulled this IC and I am now getting a new warning:

/home/joe/code/cfecfs/github/apps/ci_lab/fsw/src/ci_lab_app.c: In function ‘CI_LAB_TaskInit’:
/home/joe/code/cfecfs/github/apps/ci_lab/fsw/src/ci_lab_app.c:204:18: error: taking address of packed member of ‘struct <anonymous>’ may result in an unaligned pointer value [-Werror=address-of-packed-member]
  204 |     CFE_MSG_Init(&CI_LAB_Global.HkBuffer.HkTlm.TlmHeader.BaseMsg, CI_LAB_HK_TLM_MID, CI_LAB_HK_TLM_LNGTH);
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

@astrogeco astrogeco marked this pull request as ready for review November 13, 2020 21:13
@astrogeco astrogeco changed the title Integration candidate Integration Candidate 2020-11-10 Nov 16, 2020
@astrogeco astrogeco merged commit aa805af into main Nov 16, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove use of OS_PACK Remove dependencies on deprecated SB APIs
3 participants