Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

GQL-27: Update Collection Query to support all Collection parameters #94

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

dmistry1
Copy link
Contributor

Overview

What is the feature?

While working on MMT-3483: Implement the Collection Association Form, noticed some of the fields were missing when searching by a given field for collection.

For Example:
If I wanted to search for a collection by Entry Title using a wildcard search. Entry Title was not a field in cmr-graphql that I can search by:

	{
	  "params": {
	    "options": {
	      "EntryTitle": {
	        "pattern": true
	      }
	    },
	    "entryTitle": "*"
	  }
	}

The missing params/fields that were added are :

entryTitle
doi
revisionDate
scienceKeywords
updatedSince
version

Testing

Reproduction steps

  • Environment for testing: SIT

Entry Title

       {
	  "params": {
	    "options": {
	      "EntryTitle": {
	        "pattern": true
	      }
	    },
	    "entryTitle": "*"
	  }
	}

Science Keywords

               {
		"params": {
	    "scienceKeywords": {
	      "0": {
	        "any": "SULFUR COMPOUNDS"
	      }
	    }
	  }
	}

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1190bfa) to head (f0aeda1).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #94   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           73        73           
  Lines         1604      1604           
  Branches       215       215           
=========================================
  Hits          1604      1604           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmistry1 dmistry1 merged commit 3b2ed7d into main Feb 23, 2024
8 checks passed
@dmistry1 dmistry1 deleted the GQL-27 branch February 23, 2024 13:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants