Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

UI Components should be exposed #5288

Closed
davetsay opened this issue Jun 3, 2022 · 5 comments · Fixed by #5289 or #5290
Closed

UI Components should be exposed #5288

davetsay opened this issue Jun 3, 2022 · 5 comments · Fixed by #5289 or #5290

Comments

@davetsay
Copy link
Contributor

davetsay commented Jun 3, 2022

Description

Exposing UI components would allow developers to re-use components in their plugins.

Testing Instructions (VIPER testathon environment)

  1. Navigate to Static Objects -> Map Tool
  2. In the Map Tool, click the layers tool, and make the Instrument data -> H20 Band Depth layer visible
  3. Click on the colored portion of the layer (may have to repeat to find data)
  4. In Inspector, after data ranges load, select a data range to display plot data for that timeframe (the first data range is selected by default but may need to select a new range to see data)
  5. If the plot view loads, that is using the exposed view
@shefalijoshi
Copy link
Contributor

shefalijoshi commented Jun 9, 2022

Browser crashed (stop script warning) when I finally selected a point in the band depth with data in it. :(
Also, when i waited longer, the browser caught up, but then I had trouble performing simple tasks like minimizing the nav tree or resizing the inspector.

@unlikelyzero
Copy link
Collaborator

Given the nature of the failure. We should re-open and re-investigate based on @khalidadil 's finding

@khalidadil
Copy link
Contributor

@shefalijoshi I'm able to reproduce this on banner tesathon in Chrome but not on dev (even when dev is running the latest code). I'm not sure exactly what the issue is yet.

@davetsay
Copy link
Contributor Author

Root Cause - We are using the StackedPlot.vue component to render the plots in the inspector. The plots were changed in #5198, which breaks our usage of them. I think the code that breaks this functionality is the new stacked plot configs requiring mutation, whereas we are using temporary non-persisted stacked plot objects for temporary display only.

@shefalijoshi
Copy link
Contributor

This has been resolved by #5457

@unlikelyzero unlikelyzero added this to the Target:2.0.5 milestone Mar 20, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants