Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Expose components #5289

Merged
merged 5 commits into from
Jun 3, 2022
Merged

Expose components #5289

merged 5 commits into from
Jun 3, 2022

Conversation

davetsay
Copy link
Contributor

@davetsay davetsay commented Jun 3, 2022

Closes #5288

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #5289 (1ba821f) into master (93abc18) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5289      +/-   ##
==========================================
+ Coverage   49.72%   49.94%   +0.22%     
==========================================
  Files         557      557              
  Lines       20445    20446       +1     
  Branches     1876     1876              
==========================================
+ Hits        10166    10212      +46     
+ Misses       9787     9746      -41     
+ Partials      492      488       -4     
Impacted Files Coverage Δ
src/MCT.js 97.82% <100.00%> (+0.02%) ⬆️
src/ui/router/Browse.js 86.48% <0.00%> (-4.06%) ⬇️
src/ui/router/ApplicationRouter.js 86.31% <0.00%> (-1.06%) ⬇️
...gins/condition/components/inspector/StylesView.vue 48.53% <0.00%> (+0.87%) ⬆️
.../plugins/timeConductor/ConductorInputsRealtime.vue 50.60% <0.00%> (+1.20%) ⬆️
src/ui/components/ObjectView.vue 48.08% <0.00%> (+1.63%) ⬆️
src/api/composition/CompositionCollection.js 88.04% <0.00%> (+2.17%) ⬆️
src/ui/layout/BrowseBar.vue 47.12% <0.00%> (+2.29%) ⬆️
...c/plugins/goToOriginalAction/goToOriginalAction.js 100.00% <0.00%> (+7.14%) ⬆️
src/ui/inspector/Inspector.vue 75.00% <0.00%> (+8.33%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93abc18...1ba821f. Read the comment docs.

@akhenry akhenry merged commit 4445d71 into master Jun 3, 2022
@akhenry akhenry deleted the expose-components branch June 3, 2022 19:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Components should be exposed
2 participants