Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[e2e] Update tests to be compatible with viper #5513

Closed
7 tasks done
unlikelyzero opened this issue Jul 15, 2022 · 2 comments
Closed
7 tasks done

[e2e] Update tests to be compatible with viper #5513

unlikelyzero opened this issue Jul 15, 2022 · 2 comments
Assignees
Labels
type:maintenance tests, chores, or project maintenance
Milestone

Comments

@unlikelyzero
Copy link
Collaborator

unlikelyzero commented Jul 15, 2022

Summary

We'll need to update our test suite to be backwards compatible with VIPER execution. This is a running list:

  • Update all path in await page.goto to include a ./ instead of /
  • Update directory structure such that all fixture files resolve to the same root directory
  • Update all references to the name of the Shared Items folder and My Items. We should probably save directly to folder under My Items. Need to check with @jvigliotta and @davetsay and @akhenry to understand how prevalent this might be.
  • Update tests to navigate by URL to a domain object created in a common function like 'getOrReplace' which returns the object's uuid. Another pattern is create object with ObjectName_UUID e.g. 'Unnamed Condition Set' becomes 'ConditionSet_asdkfn_asdfnsk_' or 'ConditionSet_timestamp'. Best effort (~2 hours) Scope out for now
  • Parameterize tests so that they can use real telemetry sources or example telemetry. Create or update any associated helper functions based on the above. Start with a single test (good candidate here) as POC and example (Best effort (~2 hours)
  • Set default folder location for objects into common folder - Broken out into separate issue.
  • Include uuid and testcase info within name of object created by appActions
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Jul 15, 2022
loftwah added a commit to loftwah/openmct that referenced this issue Jul 16, 2022
@loftwah
Copy link
Contributor

loftwah commented Jul 16, 2022

I've raised a PR for this one but it looks like there are more possible changes. I am able to have a look at anything else when they come up. I hope I have read everything correctly, it would be an honour to contribute to NASA.

@unlikelyzero unlikelyzero assigned ozyx, akhenry and unlikelyzero and unassigned akhenry and ozyx Jul 17, 2022
@unlikelyzero unlikelyzero added this to the Sprint:2.0.7 milestone Jul 18, 2022
@unlikelyzero
Copy link
Collaborator Author

@loftwah thanks for taking this one on! It's going to grow quite spectacularly, but that was definitely the most important step. If you don't mind, would you mind moving to the Discussion board to talk about taking on another testing task?

I just stumbled upon #3213 (comment)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

No branches or pull requests

4 participants