Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Menus in Snow theme have no border #5556

Closed
3 of 7 tasks
davetsay opened this issue Jul 25, 2022 · 2 comments · Fixed by #5557
Closed
3 of 7 tasks

Menus in Snow theme have no border #5556

davetsay opened this issue Jul 25, 2022 · 2 comments · Fixed by #5557
Labels
bug:regression It used to work. Now it doesn't :( type:bug

Comments

@davetsay
Copy link
Contributor

davetsay commented Jul 25, 2022

Summary

In snow theme the menus - create, 3-dot, context - are missing some border and drop shadow styling

Expected vs Current Behavior

Border and drop shadow

Steps to Reproduce

  1. open browser console
  2. use openmct.install(openmct.plugins.Snow()) and openmct.install(openmct.plugins.Espresso()) to toggle themes
  3. compare menus (create, context, 3-dot) in Snow and Espresso themes

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@davetsay davetsay added the bug:regression It used to work. Now it doesn't :( label Jul 25, 2022
charlesh88 added a commit that referenced this issue Jul 25, 2022
@charlesh88
Copy link
Contributor

charlesh88 commented Jul 25, 2022

Testing Notes

  1. In the Espresso theme, make sure that the Create menu and More Options (3 dot) menus flyouts all look as expected:

Screen Shot 2022-07-25 at 3 10 40 PM

  1. Switch to the Snow theme, make sure that a drop shadow appears beneath menus and hovering over a menu item shows both text and icon in a light color. The theme can be changed on-the-fly or remotely by entering this command in the browser console:
    openmct.install(openmct.plugins.Snow())

Screen Shot 2022-07-25 at 2 38 41 PM

@michaelrogers
Copy link
Contributor

michaelrogers commented Aug 4, 2022

This fix is verified during testathon 08/04/2022. Border and drop shadow styling is present for context menus in the MCT tree, three dot menu, and inspector time bounds overlays.
Screen Shot 2022-08-04 at 4 57 58 PM

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug:regression It used to work. Now it doesn't :( type:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants