Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Entries being lost in notebooks #6675

Closed
3 of 7 tasks
akhenry opened this issue May 17, 2023 · 8 comments
Closed
3 of 7 tasks

Entries being lost in notebooks #6675

akhenry opened this issue May 17, 2023 · 8 comments

Comments

@akhenry
Copy link
Contributor

akhenry commented May 17, 2023

Summary

Multiple users have reported losing notebook entries. The notebook entries appear to be added but upon navigating away and back the entries are gone. These issues have been observed even in notebooks that only have a single concurrent user, open in a single tab, suggesting that this is not a persistence conflict.

The persistence call to save a notebook entry could be getting backed up behind other pending requests and is never successfully persisted. Aside from reducing the number of requests overall, this could be improved by providing better user feedback, like an activity indicator that shows when an entry is saving. We should also prevent a user from adding additional entries when a persistence operation is taking place, this will highlight to the user sooner that a problem has occurred and reduce the amount of work lost.

There may also be some as-yet unknown issue with persisting notebook entries.

Steps to Reproduce

Exact steps are unknown at this point. Try adding entries to a single-user notebook with heavy network throttling in place.

Environment

  • Open MCT Version: 2.2.0
  • Deployment Type: MMOC

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?
@akhenry akhenry added this to the Target:2.2.4 milestone May 17, 2023
@unlikelyzero
Copy link
Collaborator

Might be possible with a restart to Apache if you already have a notebook open.

@ozyx
Copy link
Contributor

ozyx commented May 18, 2023

I’m able to reproduce by doing the following:

With two instances of chrome open (one chrome, one chromium):

  1. Throttle chrome to slow 3g
  2. Navigate both browsers to the display layout containing the notebook
  3. On the throttled chrome, create a new page, name it, and then create an entry
  4. While those are saving (progress bar is going), edit an existing entry on another page on the non-throttled browser
  5. The new entry added on the throttled browser disappears after a “conflict detected” warning

@akhenry akhenry modified the milestones: Target:2.2.5, Target:3.0.0 Jul 31, 2023
@akhenry akhenry changed the title Entries being lost in multi-user notebooks Entries being lost in notebooks Jul 31, 2023
@akhenry
Copy link
Contributor Author

akhenry commented Aug 1, 2023

I've found the issue, it's related to transactions. I don't know exactly how users are getting the application into this state (although I have found one reliable reproduction path), but once they do it's difficult to recover.

Here's how I reproduced it. It's probably not how users are doing it in production, but hopefully enough for us to fix it.

  1. Open a notebook
  2. In dev tools, open the network tab and set throttling to "Slow 3G"
  3. Add a new notebook entry and then very quickly navigate away to another object.
  4. Navigate back to the notebook. Observe that the new entry section at the top is disabled. If it's not repeat steps 4 and 5 until it is.
  5. Navigate away and back again
  6. Observe that the new entry section is now enabled again.
  7. In dev tools, clear network tab
  8. Add several new entries and observe that no network traffic is created, the entries are not persisted.
  9. Refresh the notebook and observe that any entries added after step 8 are gone.

@akhenry akhenry assigned akhenry and unassigned charlesh88 and jvigliotta Aug 1, 2023
@akhenry
Copy link
Contributor Author

akhenry commented Aug 1, 2023

Although I can reproduce this issue using the above steps in version 2.2.0 of Open MCT in our VIPER MMOC environment, I cannot reproduce it in 3.0.0 snapshot. Closing to retest.

@akhenry
Copy link
Contributor Author

akhenry commented Aug 1, 2023

Testing Instructions

Follow reproduction steps in #6675 (comment) and verify that the issue cannot be reproduced.

@khalidadil
Copy link
Contributor

I'm not able to reproduce step #4 where the entry section at the top is disabled.

@ozyx
Copy link
Contributor

ozyx commented Aug 1, 2023

Cannot reproduce. Fixed(?)

@ozyx ozyx removed the unverified label Aug 1, 2023
@davetsay
Copy link
Contributor

davetsay commented Aug 1, 2023

throttled network and tried to stress the network by opening several instances of the map tool. could not reproduce loss of entries.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

7 participants