Allow form file input to accept other MIME types #6089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6089 +/- ##
==========================================
- Coverage 54.65% 54.63% -0.02%
==========================================
Files 600 600
Lines 23940 23950 +10
Branches 2115 2117 +2
==========================================
+ Hits 13084 13085 +1
- Misses 10256 10265 +9
Partials 600 600
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
davetsay
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
khalidadil
reviewed
Jan 17, 2023
| value: fileInfo | ||
| }; | ||
|
|
||
| this.$emit('onChange', data); |
There was a problem hiding this comment.
Is there any way this could be used to do something malicious using a file with some executable code?
khalidadil
approved these changes
Jan 17, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6088
Describe your changes:
Allow dev to specify
acceptattribute on form file inputs.jsonfiles handling remains unchanged, but for now all other types are passed onto form callback without being read in.All Submissions:
Author Checklist
Reviewer Checklist