Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Multiple Y-Axis] Fix pan/zoom/history for multiple-y axis #6126

Merged
merged 9 commits into from
Jan 19, 2023

Conversation

khalidadil
Copy link
Contributor

@khalidadil khalidadil commented Jan 17, 2023

Closes #6051

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (feature/plots-multiple-y-axes@8b3487b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                       Coverage Diff                        @@
##             feature/plots-multiple-y-axes    #6126   +/-   ##
================================================================
  Coverage                                 ?   54.79%           
================================================================
  Files                                    ?      602           
  Lines                                    ?    24135           
  Branches                                 ?     2165           
================================================================
  Hits                                     ?    13225           
  Misses                                   ?    10302           
  Partials                                 ?      608           
Flag Coverage Δ *Carryforward flag
e2e-ci 39.49% <0.00%> (?) Carriedforward from 90f60ae
e2e-full 51.23% <0.00%> (?) Carriedforward from 90f60ae
e2e-stable 50.25% <0.00%> (?)
unit 50.36% <0.00%> (?)

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b3487b...d8a6c4d. Read the comment docs.

@shefalijoshi shefalijoshi self-requested a review January 19, 2023 15:26
Copy link
Contributor

@shefalijoshi shefalijoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Thank you!

@khalidadil khalidadil merged commit 97ae390 into feature/plots-multiple-y-axes Jan 19, 2023
ozyx pushed a commit that referenced this pull request Jan 20, 2023
* Fix wheelzoom

* Fix button zoom

* Fix pan

* Fix history

* fix marquee for plot zoom - Ensure the rectangles follow the marquee object and are drawn relevant to the yAxis

* Update yScale check to test all axes

Co-authored-by: Shefali <simplyrender@gmail.com>
@khalidadil khalidadil deleted the bugfix/issue-6051 branch February 8, 2023 09:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants