cherry-pick(#5997): Make tree items more actionable and add AppAction for expanding the object tree #6200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for expanding the object tree * style: add `visibility` to tree expand triangles - The purpose of this is so that Playwright can perform actionability checks on the tree items. This will make operations involving expanding tree items much easier to perform in e2e. * feat(e2e): Add AppAction to expand the entire tree * fix: wait for loading indicator * test: add test for `expandEntireTree` * test: update `expandEntireTree` and tree selectors - Use dynamic aria-label for different tree implementations - Get rid of CSS ids which are only for testing - Update percy tree scope selector * chore(lint): remove unused variable * refactor(e2e): update tree locators Co-authored-by: John Hill <john.c.hill@nasa.gov>
Codecov Report
@@ Coverage Diff @@
## release/2.1.6 #6200 +/- ##
================================================
Coverage ? 54.70%
================================================
Files ? 607
Lines ? 25943
Branches ? 2350
================================================
Hits ? 14191
Misses ? 11088
Partials ? 664
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report at Codecov.
|
unlikelyzero
approved these changes
Jan 26, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
visibilityto tree expand trianglesfeat(e2e): Add AppAction to expand the entire tree
fix: wait for loading indicator
test: add test for
expandEntireTreetest: update
expandEntireTreeand tree selectorsUse dynamic aria-label for different tree implementations
Get rid of CSS ids which are only for testing
Update percy tree scope selector
chore(lint): remove unused variable
refactor(e2e): update tree locators
Co-authored-by: John Hill john.c.hill@nasa.gov