Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix race condition in image annotations loading and drawing them on the canvas #6751

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

scottbell
Copy link
Contributor

@scottbell scottbell commented Jun 21, 2023

Closes #6749

Describe your changes:

Fixes race condition between loading the image annotations and drawing them on canvas.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@scottbell scottbell linked an issue Jun 21, 2023 that may be closed by this pull request
7 tasks
@scottbell scottbell requested a review from ozyx June 21, 2023 11:29
@deploysentinel
Copy link

deploysentinel bot commented Jun 21, 2023

Current Playwright Test Results Summary

✅ 13 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 06/21/2023 06:11:03pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 437310d

Started: 06/21/2023 06:09:28pm UTC

View Detailed Build Results


@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #6751 (f7df3ab) into master (f254d4f) will increase coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #6751      +/-   ##
==========================================
+ Coverage   53.79%   53.89%   +0.10%     
==========================================
  Files         624      624              
  Lines       24847    24848       +1     
  Branches     2493     2493              
==========================================
+ Hits        13366    13393      +27     
+ Misses      10813    10788      -25     
+ Partials      668      667       -1     
Flag Coverage Δ *Carryforward flag
e2e-full 42.14% <ø> (ø) Carriedforward from 03a9309
e2e-stable 55.25% <ø> (-0.30%) ⬇️
unit 48.66% <0.00%> (+0.17%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...c/plugins/imagery/components/AnnotationsCanvas.vue 2.63% <0.00%> (-0.02%) ⬇️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f254d4f...f7df3ab. Read the comment docs.

@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 21, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 21, 2023
@ozyx ozyx added this to the Target:2.2.6 milestone Jun 21, 2023
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally and seems to work well

@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 21, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 21, 2023
@scottbell scottbell merged commit d8ac209 into master Jun 21, 2023
@scottbell scottbell deleted the 6749-imagery-annotations-dont-appear-on-mount branch June 21, 2023 18:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imagery annotations don't appear on mount
2 participants