Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feat(tooling): add cspell #6892

Merged
merged 4 commits into from
Aug 9, 2023
Merged

Conversation

evenstensberg
Copy link
Contributor

Describe your changes:

Adds tool to spellcheck code

#6888

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Aug 6, 2023

Current Playwright Test Results Summary

✅ 134 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/08/2023 11:02:14pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 10b8a11

Started: 08/08/2023 10:55:20pm UTC

⚠️ Flakes

📄   functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1Initial Attempt
0% (0) 0 / 96 runs
failed over last 7 days
23.96% (23) 23 / 96 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #6892 (10b8a11) into master (1e3097f) will increase coverage by 0.94%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6892      +/-   ##
==========================================
+ Coverage   46.98%   47.92%   +0.94%     
==========================================
  Files         643      643              
  Lines       25627    25627              
  Branches     2496     2496              
==========================================
+ Hits        12040    12281     +241     
+ Misses      13111    12870     -241     
  Partials      476      476              
Flag Coverage Δ *Carryforward flag
e2e-full 42.03% <ø> (ø) Carriedforward from 1bb3c0d
e2e-stable 53.23% <ø> (+0.05%) ⬆️
unit 38.77% <ø> (+0.02%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 76 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e3097f...10b8a11. Read the comment docs.

@evenstensberg
Copy link
Contributor Author

Make sure to go through all words in .cspell.json and remove any unknown or misspelt words.

@ozyx ozyx added the source:community Community contribution or request label Aug 7, 2023
package.json Outdated Show resolved Hide resolved
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Aug 7, 2023
@unlikelyzero unlikelyzero added this to the Target:3.1.0 milestone Aug 7, 2023
@evenstensberg
Copy link
Contributor Author

@unlikelyzero this PR is ready to be merged, you can submit fixes to wrongly spelt words later

@unlikelyzero
Copy link
Collaborator

Can you update our circle CI config to run this immediately after the current lint process?

@evenstensberg
Copy link
Contributor Author

Done

@unlikelyzero unlikelyzero enabled auto-merge (squash) August 8, 2023 22:52
@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 8, 2023
@evenstensberg
Copy link
Contributor Author

Needs Percy approvals

@unlikelyzero unlikelyzero added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels Aug 9, 2023
@unlikelyzero unlikelyzero merged commit 58aeac9 into nasa:master Aug 9, 2023
11 of 12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pr:e2e:couchdb npm run test:e2e:couchdb source:community Community contribution or request type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants