Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Progress Bar Display #6952

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Progress Bar Display #6952

merged 2 commits into from
Aug 18, 2023

Conversation

depperm
Copy link
Contributor

@depperm depperm commented Aug 17, 2023

Closes #6516

Describe your changes:

Added Minimum height to progress bar, bar

Testing

I added <progress-bar :model=" {progressPerc: 74}" /> to Webpage.vue (don't forget import ProgressBar from '../../../ui/components/ProgressBar.vue' right after <script> and components: { ProgressBar }, before inject)

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Aug 17, 2023

Current Playwright Test Results Summary

✅ 136 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/18/2023 10:54:40pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: a77bf59

Started: 08/18/2023 10:48:02pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
0% (0) 0 / 154 runs
failed over last 7 days
43.51% (67) 67 / 154 runs
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 153 runs
failed over last 7 days
42.48% (65) 65 / 153 runs
flaked over last 7 days

📄   functional/plugins/plot/tagging.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Plot Tagging Tags work with Overlay Plots
Retry 1Initial Attempt
11.11% (17) 17 / 153 runs
failed over last 7 days
26.14% (40) 40 / 153 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #6952 (a77bf59) into master (bada228) will decrease coverage by 1.83%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6952      +/-   ##
==========================================
- Coverage   48.69%   46.87%   -1.83%     
==========================================
  Files         643      643              
  Lines       25719    25719              
  Branches     2512     2512              
==========================================
- Hits        12525    12056     -469     
- Misses      12692    13182     +490     
+ Partials      502      481      -21     
Flag Coverage Δ *Carryforward flag
e2e-full 42.06% <ø> (+0.04%) ⬆️ Carriedforward from afca033
e2e-stable 53.35% <ø> (-3.82%) ⬇️
unit 38.67% <ø> (-0.68%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 62 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bada228...a77bf59. Read the comment docs.

@ozyx ozyx added the source:community Community contribution or request label Aug 17, 2023
@ozyx ozyx requested review from charlesh88 and ozyx August 18, 2023 21:57
@ozyx ozyx added this to the Target:3.1.0 milestone Aug 18, 2023
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! This LGTM. Thank you!

@@ -25,6 +25,7 @@
&__bar {
background: $colorProgressBar;
height: 100%;
min-height: $progressBarMinH;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice catch!

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 18, 2023
@ozyx ozyx enabled auto-merge (squash) August 18, 2023 22:50
@ozyx ozyx disabled auto-merge August 18, 2023 22:50
@ozyx ozyx enabled auto-merge (squash) August 18, 2023 22:51
@ozyx ozyx merged commit a495e86 into nasa:master Aug 18, 2023
14 of 15 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pr:e2e:couchdb npm run test:e2e:couchdb source:community Community contribution or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress Bar does not show progress percentage
2 participants