Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

cherry-pick(#6948): Ensure that dynamically created vue components are destroyed #6958

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Aug 18, 2023

Original issue: VIPEROMCT-392

@deploysentinel
Copy link

deploysentinel bot commented Aug 18, 2023

Current Playwright Test Results Summary

✅ 137 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/21/2023 06:40:44pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: fa09d44

Started: 08/21/2023 06:34:05pm UTC

⚠️ Flakes

📄   functional/plugins/conditionSet/conditionSet.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Basic Condition Set Use ConditionSet should output blank instead of the default value
Retry 1Initial Attempt
13.56% (8) 8 / 59 runs
failed over last 7 days
28.81% (17) 17 / 59 runs
flaked over last 7 days

📄   functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1Initial Attempt
4.76% (7) 7 / 147 runs
failed over last 7 days
16.33% (24) 24 / 147 runs
flaked over last 7 days

📄   functional/plugins/plot/autoscale.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Autoscale User can set autoscale with a valid range @snapshot
Retry 2Retry 1Initial Attempt
0% (0) 0 / 154 runs
failed over last 7 days
5.19% (8) 8 / 154 runs
flaked over last 7 days

View Detailed Build Results


@ozyx ozyx changed the title cherry-pick(6984): Ensure that dynamically created vue components are destroyed. (#6948) cherry-pick(#6948): Ensure that dynamically created vue components are destroyed Aug 18, 2023
@ozyx ozyx added this to the Target:3.0.1 milestone Aug 18, 2023
@ozyx
Copy link
Contributor

ozyx commented Aug 18, 2023

Please add a link to the issue(s) the original PR is closing in the body of the cherry-pick PR for traceability

Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davetsay
Copy link
Contributor

@shefalijoshi , approved but visual tests are failing

@davetsay davetsay closed this Aug 21, 2023
@davetsay davetsay reopened this Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/3.0.1@c3ac07e). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head b41f0a0 differs from pull request most recent head fa09d44. Consider uploading reports for the commit fa09d44 to get more accurate results

@@               Coverage Diff                @@
##             release/3.0.1    #6958   +/-   ##
================================================
  Coverage                 ?   42.04%           
================================================
  Files                    ?      409           
  Lines                    ?    12639           
  Branches                 ?        0           
================================================
  Hits                     ?     5314           
  Misses                   ?     7325           
  Partials                 ?        0           
Flag Coverage Δ
e2e-full 42.04% <0.00%> (?)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3ac07e...fa09d44. Read the comment docs.

@davetsay davetsay enabled auto-merge (squash) August 21, 2023 18:37
@davetsay davetsay merged commit 856d885 into release/3.0.1 Aug 21, 2023
3 of 4 checks passed
@davetsay davetsay deleted the cherry-pick-6948 branch August 21, 2023 18:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants