-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Ensure CouchDB changes for plans trigger updates in the view #7099
Conversation
…trigger a property only event. It triggers a catchall '*' event.
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/02/2023 11:25:24pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 9091358 Started: 10/02/2023 11:23:27pm UTC Current Playwright Test Results Summary✅ 141 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/02/2023 11:25:24pm UTC)
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Timer Can perform actions on the Timer
Retry 1 • Initial Attempt |
0% (0)0 / 92 runsfailed over last 7 days |
8.70% (8)8 / 92 runsflaked over last 7 days |
📄 functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1 • Initial Attempt |
0% (0)0 / 92 runsfailed over last 7 days |
23.91% (22)22 / 92 runsflaked over last 7 days |
📄 functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
7% (7)7 / 100 runsfailed over last 7 days |
25% (25)25 / 100 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
0.76% (1)1 / 132 runfailed over last 7 days |
55.30% (73)73 / 132 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
8.60% (8)8 / 93 runsfailed over last 7 days |
44.09% (41)41 / 93 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #7099 +/- ##
==========================================
- Coverage 55.55% 55.35% -0.20%
==========================================
Files 650 650
Lines 26090 26090
Branches 2549 2549
==========================================
- Hits 14494 14442 -52
- Misses 10890 10954 +64
+ Partials 706 694 -12
*This pull request uses carry forward flags. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to work?
I loaded up this branch in the VIPER testing environment, navigated to a VIPER plan and then made changes directly to the plan (changed an activity name) using the CouchDB utils interface. The plan did not update until I navved away / back again.
Is this not the correct way to test? How should this be tested?
Edit: It works, the issue was my local proxy setup.
It appears that the couchdb feed does not work as expected when using a proxy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it works. The issue was my local proxy setup 🤦.
Great catch!
Closes #7098 7098
Describe your changes:
Listen to ALL changes for a plan since couchdb feed updates does not trigger a property only event. It triggers a catchall '*' event.
See: https://github.com/nasa/openmct/blob/fix-plan-updates/src/api/objects/ObjectAPI.js#L671
All Submissions:
Author Checklist
Reviewer Checklist