Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Documentation] Time API docs update new/deprecated functionality #7107

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

jvigliotta
Copy link
Contributor

@jvigliotta jvigliotta commented Oct 3, 2023

Closes #6799

Describe your changes:

Updated docs to reflect added/removed functionality.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Oct 3, 2023

Current Playwright Test Results Summary

✅ 14 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/03/2023 06:18:07pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 3f69cd4

Started: 10/03/2023 06:13:47pm UTC

⚠️ Flakes

📄   functional/plugins/displayLayout/displayLayout.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb
Retry 1Initial Attempt
2.27% (1) 1 / 44 run
failed over last 7 days
20.45% (9) 9 / 44 runs
flaked over last 7 days

📄   functional/couchdb.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
CouchDB Status Indicator with mocked responses @couchdb Shows red if not connected
Retry 1Initial Attempt
0% (0) 0 / 44 runs
failed over last 7 days
2.27% (1) 1 / 44 run
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 141 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/03/2023 06:18:07pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 3f69cd4

Started: 10/03/2023 06:12:26pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
17.20% (16) 16 / 93 runs
failed over last 7 days
54.84% (51) 51 / 93 runs
flaked over last 7 days

View Detailed Build Results


@ozyx ozyx added this to the Target:3.1.0 milestone Oct 3, 2023
Copy link
Contributor

@shefalijoshi shefalijoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

API.md Outdated Show resolved Hide resolved
API.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #7107 (3f69cd4) into master (b1169ff) will decrease coverage by 6.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7107      +/-   ##
==========================================
- Coverage   55.60%   49.30%   -6.30%     
==========================================
  Files         650      413     -237     
  Lines       26090    12795   -13295     
  Branches     2549        0    -2549     
==========================================
- Hits        14507     6309    -8198     
+ Misses      10886     6486    -4400     
+ Partials      697        0     -697     
Flag Coverage Δ *Carryforward flag
e2e-full 41.92% <ø> (ø) Carriedforward from 94aa5a6
e2e-stable 45.22% <ø> (-11.81%) ⬇️
unit ?

*This pull request uses carry forward flags. Click here to find out more.

see 469 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1169ff...3f69cd4. Read the comment docs.

@shefalijoshi shefalijoshi added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 3, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 3, 2023
@ozyx ozyx enabled auto-merge (squash) October 3, 2023 18:10
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 3, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 3, 2023
@ozyx ozyx merged commit d973140 into master Oct 3, 2023
12 of 13 checks passed
@ozyx ozyx deleted the time-docs branch October 3, 2023 18:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document new Time API functions
3 participants