do not store state in singleton action

[davetsay]

Re Closes #7089

Describe your changes:

Scope new objects to create to the function itself

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

• Changes address original issue?
• Tests included and/or updated with changes?
• Command line build passes?
• Has this been smoke tested?
• Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

• Changes appear to address issue?
• Reviewer has tested changes by following the provided instructions?
• Changes appear not to be breaking changes?
• Appropriate automated tests included?
• Code style and in-line documentation are appropriate?
• Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
• Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

[deploysentinel]

Current Playwright Test Results Summary

✅ 14 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/10/2023 09:32:53pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 4de255a

Started: 10/10/2023 09:30:15pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/notebookWithCouchDB.e2e.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests Retry 1 • Initial Attempt	2.13% (1) 1 / 47 run failed over last 7 days	8.51% (4) 4 / 47 runs flaked over last 7 days

---

View Detailed Build Results

---

Current Playwright Test Results Summary

✅ 141 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/10/2023 09:32:53pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 4de255a

Started: 10/10/2023 08:32:01pm UTC

⚠️ Flakes

📄   functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Telemetry Table unpauses and filters data when paused by button and user changes bounds Retry 1 • Initial Attempt	0% (0) 0 / 76 runs failed over last 7 days	15.79% (12) 12 / 76 runs flaked over last 7 days

---

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Example Imagery in Display Layout View Large action leaves keeps realtime mode paused Retry 1 • Initial Attempt	0% (0) 0 / 80 runs failed over last 7 days	6.25% (5) 5 / 80 runs flaked over last 7 days

---

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds Retry 1 • Initial Attempt	1.79% (2) 2 / 112 runs failed over last 7 days	58.93% (66) 66 / 112 runs flaked over last 7 days

---

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry Retry 1 • Initial Attempt	6.17% (5) 5 / 81 runs failed over last 7 days	56.79% (46) 46 / 81 runs flaked over last 7 days

---

View Detailed Build Results

---

[codecov]

Codecov Report

Merging #7121 (4de255a) into master (97b2ebc) will increase coverage by 0.02%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #7121      +/-   ##
==========================================
+ Coverage   55.80%   55.82%   +0.02%     
==========================================
  Files         651      651              
  Lines       26114    26114              
  Branches     2521     2521              
==========================================
+ Hits        14572    14578       +6     
+ Misses      10841    10839       -2     
+ Partials      701      697       -4     

Flag	Coverage Δ		*Carryforward flag
e2e-full	41.89% <ø> (+0.01%)	⬆️	Carriedforward from 5e0827a
e2e-stable	57.30% <0.00%> (-0.03%)	⬇️
unit	49.39% <71.42%> (+0.04%)	⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files	Coverage Δ
...ugins/importFromJSONAction/ImportFromJSONAction.js	65.26% <71.42%> (ø)

... and 10 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97b2ebc...4de255a. Read the comment docs.

[akhenry]

Looks great, thanks @davetsay ! Nice work.