Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename all configuration tabs to Config #7140

Merged
merged 6 commits into from
Oct 12, 2023
Merged

Rename all configuration tabs to Config #7140

merged 6 commits into from
Oct 12, 2023

Conversation

davetsay
Copy link
Contributor

@davetsay davetsay commented Oct 12, 2023

Closes #7135

Describe your changes:

Renamed outlier tabs to Config
Fixed associated unit tests

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Oct 12, 2023

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/12/2023 08:31:29pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 6578b80

Started: 10/12/2023 08:29:34pm UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 143 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/12/2023 08:31:29pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 6578b80

Started: 10/12/2023 08:13:19pm UTC

⚠️ Flakes

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery in Display Layout View Large action leaves keeps realtime mode paused
Retry 1Initial Attempt
0% (0) 0 / 70 runs
failed over last 7 days
8.57% (6) 6 / 70 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 62 runs
failed over last 7 days
38.71% (24) 24 / 62 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
1.96% (2) 2 / 102 runs
failed over last 7 days
61.76% (63) 63 / 102 runs
flaked over last 7 days

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
4.41% (3) 3 / 68 runs
failed over last 7 days
57.35% (39) 39 / 68 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #7140 (6578b80) into master (26d3bd1) will increase coverage by 0.87%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7140      +/-   ##
==========================================
+ Coverage   54.85%   55.73%   +0.87%     
==========================================
  Files         651      651              
  Lines       26170    26170              
  Branches     2535     2535              
==========================================
+ Hits        14356    14585     +229     
+ Misses      11119    10887     -232     
- Partials      695      698       +3     
Flag Coverage Δ *Carryforward flag
e2e-full 41.94% <ø> (ø) Carriedforward from 73b0bae
e2e-stable 57.31% <ø> (+3.05%) ⬆️
unit 49.28% <ø> (-0.06%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...rts/bar/inspector/BarGraphInspectorViewProvider.js 100.00% <ø> (ø)
...Management/FaultManagementInspectorViewProvider.js 58.33% <ø> (ø)
...s/telemetryTable/TableConfigurationViewProvider.js 62.50% <ø> (ø)

... and 29 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26d3bd1...6578b80. Read the comment docs.

@davetsay davetsay added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 12, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 12, 2023
@ozyx ozyx self-requested a review October 12, 2023 20:36
@ozyx ozyx added this to the Target:3.2.0 milestone Oct 12, 2023
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davetsay davetsay merged commit 76889cf into master Oct 12, 2023
22 checks passed
@davetsay davetsay deleted the issue/7135 branch October 12, 2023 20:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telemetry Tables Configuration tab should be renamed to Config to match other tabs
2 participants