Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Extend conditional #7868

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Conversation

khalidadil
Copy link
Contributor

Closes

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 5.37190% with 229 lines in your changes missing coverage. Please review.

Project coverage is 50.20%. Comparing base (de122b9) to head (cba2056).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
...c/plugins/condition/HistoricalTelemetryProvider.js 0.00% 145 Missing ⚠️
src/plugins/condition/ConditionManager.js 0.00% 63 Missing ⚠️
...lugins/condition/ConditionInspectorViewProvider.js 18.18% 9 Missing ⚠️
.../plugins/condition/ConditionSetMetadataProvider.js 0.00% 7 Missing ⚠️
...gins/plot/stackedPlot/mixins/objectStyles-mixin.js 70.00% 3 Missing ⚠️
...plugins/condition/ConditionSetTelemetryProvider.js 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (de122b9) and HEAD (cba2056). Click for more details.

HEAD has 40 uploads less than BASE
Flag BASE (de122b9) HEAD (cba2056)
unit 19 0
e2e-full 18 1
e2e-ci 7 3
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7868      +/-   ##
==========================================
- Coverage   59.18%   50.20%   -8.99%     
==========================================
  Files         675      435     -240     
  Lines       27284    13755   -13529     
  Branches     2671        0    -2671     
==========================================
- Hits        16149     6906    -9243     
+ Misses      11088     6849    -4239     
+ Partials       47        0      -47     
Flag Coverage Δ
e2e-ci 50.11% <5.37%> (-11.67%) ⬇️
e2e-full 23.20% <1.65%> (-18.77%) ⬇️
unit ?
Files with missing lines Coverage Δ
src/plugins/condition/plugin.js 100.00% <100.00%> (ø)
src/plugins/condition/utils/constants.js 100.00% <100.00%> (ø)
src/plugins/plot/tickUtils.js 74.64% <100.00%> (-22.54%) ⬇️
...plugins/condition/ConditionSetTelemetryProvider.js 9.52% <0.00%> (-85.48%) ⬇️
...gins/plot/stackedPlot/mixins/objectStyles-mixin.js 85.41% <70.00%> (+1.10%) ⬆️
.../plugins/condition/ConditionSetMetadataProvider.js 16.66% <0.00%> (-83.34%) ⬇️
...lugins/condition/ConditionInspectorViewProvider.js 18.18% <18.18%> (ø)
src/plugins/condition/ConditionManager.js 0.00% <0.00%> (-91.00%) ⬇️
...c/plugins/condition/HistoricalTelemetryProvider.js 0.00% <0.00%> (ø)

... and 441 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de122b9...cba2056. Read the comment docs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants