Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Check fcntl return status or explicitly (void) #863

Closed
skliper opened this issue Mar 10, 2021 · 0 comments · Fixed by #910, #917 or #925
Closed

Check fcntl return status or explicitly (void) #863

skliper opened this issue Mar 10, 2021 · 0 comments · Fixed by #910, #917 or #925
Assignees
@jphickey
Labels
CFS-38 enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Mar 10, 2021

Is your feature request related to a problem? Please describe.
Return status not checked/reported

osal/src/os/portable/os-impl-bsd-sockets.c

Line 364 in ead5723

fcntl(conn_impl->fd, F_SETFL, os_flags);

Describe the solution you'd like
Add check and debug error output or explicitly void. Need to resolve w/ documentation research.

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC, OSAL code review
@skliper skliper added this to the 6.0.0 milestone Mar 10, 2021
jphickey added a commit to jphickey/osal that referenced this issue Mar 15, 2021
@jphickey
Fix nasa#863, check/report fcntl status
28b550d 
The fcntl() function is documented as returning -1 on error, so
test for this condition and report errno if so.  There is no
recourse/handling - this just reports the error.

However - failure to set the O_NONBLOCK flag via this method
will fall back to blocking mode being used (timeouts will not
work as a result).
@jphickey jphickey mentioned this issue Mar 15, 2021
Merged
jphickey added a commit to jphickey/osal that referenced this issue Mar 15, 2021
@jphickey
Fix nasa#863, check/report fcntl status
c11c9a6 
The fcntl() function is documented as returning -1 on error, so
test for this condition and report errno if so.  There is no
recourse/handling - this just reports the error.

However - failure to set the O_NONBLOCK flag via this method
will fall back to blocking mode being used (timeouts will not
work as a result).
@astrogeco astrogeco mentioned this issue Mar 19, 2021
Merged
astrogeco added a commit that referenced this issue Mar 23, 2021
@astrogeco
Merge pull request #910 from jphickey/fix-863-fcntl-status
97c23c9 
Fix #863, check/report fcntl status

Fix Version and Readme to reflect correct buildnumber:350
@astrogeco astrogeco mentioned this issue Mar 23, 2021
Merged
@jphickey jphickey mentioned this issue May 6, 2021
Closed
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
Fix nasa#863, Add debug message from SendEvents
442aa36
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@yammajamma
Merge pull request nasa#864 from skliper/fix863-debugmsg-events
5c296a8 
Fix nasa#863, Add debug message from SendEvents
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@jphickey jphickey

Labels
CFS-38 enhancement
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @skliper