Fix #618, Use osal_id_t in RTEMS implementation #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change use of uint32 for ID to the correct typedef. Use ObjectIdFromInteger/ObjectIdToInteger where it is intended to convert these values to integers e.g. for the "name" fields in RTEMS.
jphickey
added
the
CCB:Ready
|
CCB 2020-10-06 APPROVED |
astrogeco
added
IC-20201013
and removed
CCB:Ready
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#591, Avoid deadlock in CFE_ES_CreatObjects
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Change use of uint32 for ID to the correct typedef. Also use ObjectIdFromInteger/ObjectIdToInteger where it is intended to
convert these values to integers e.g. for the "name" fields in RTEMS.
Fixes #618
Testing performed
Build and sanity test CFE on RTEMS
Confirm all unit tests working
Expected behavior changes
None
System(s) tested on
RTEMS 4.11.3 / pc686 (QEMU) via Ubuntu 20.04 build host
Additional context
For consistency with all other modules
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.