Fix #916, scrub include guards #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure all headers have a consistent include guard and file block comment This gets all FSW code within src/os and src/bsp.
Ensure all headers have a consistent include guard and file block comment This gets all unit tests (function, not coverage) and ut assert
|
Pushed as draft to get started, this covers the actual FSW code in src/os and src/bsp as well as functional tests and ut assert. I still need to run the script against the coverage stuff in src/unit-test-coverage (this alone has another 180+ headers in it) but the script wasn't working as well against those files (yet) so I didn't include them in the set for now. |
Scrub all include guards and file scope doxygen comments in src/unit-test-coverage
jphickey
added
the
CCB:Ready
Filter out author and creation date info (not relevant)
skliper
approved these changes
Mar 25, 2021
|
CCB:2021-03-31 APPROVED
|
astrogeco
added
CCB:Approved
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 8, 2021
nasa/osal#931 - Scrub include guards nasa/osal#937 - Switch to use CLOCK_REALTIME nasa/osal#938 - Specify shell name in ShellOutputToFile
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 8, 2021
Combines: nasa/cFE#1284 nasa/osal#951 nasa/PSP#289 Including: nasa/cFE#1251 - ES Info API Functional test nasa/osal#931 - Scrub include guards nasa/osal#937 - Switch to use CLOCK_REALTIME nasa/osal#938 - specify shell name in ShellOutputToFile nasa/PSP#286 - use OSAL timebase for CFE timers nasa/PSP#282 - modularize the ram, port, and eenasa/psp#om access nasa/PSP#285 - add psp module to implement timebase
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Apply script to scrub all header file block comments and include guards on OSAL.
Fixes #916
Testing performed
Build and sanity check, run all unit tests
Expected behavior changes
None, comment and ifdef consistency fixups only
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.