Fix #45, Move cmds and utils into separate files #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /* Output CRC */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| void SAMPLE_APP_GetCrc(const char *TableName) |
Check notice
Code scanning / CodeQL
Long function without assertion
| /* Verify command packet length */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * **/ | ||
| bool SAMPLE_APP_VerifyCmdLength(CFE_MSG_Message_t *MsgPtr, size_t ExpectedLength) |
Check notice
Code scanning / CodeQL
Long function without assertion
| /* This function Process Ground Station Command */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| int32 SAMPLE_APP_Process(const SAMPLE_APP_ProcessCmd_t *Msg) |
Check notice
Code scanning / CodeQL
Long function without assertion
jphickey
approved these changes
Oct 26, 2023
jphickey
added
the
CCB:Ready
dzbaker
added
CCB:Approved
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 30, 2023
*Combines:* sample_app v1.3.0-rc4+dev56 ci_lab v2.5.0-rc4+dev51 sch_lab v2.5.0-rc4+dev61 **Includes:** *sample_app* - nasa/sample_app#189 - nasa/sample_app#195 - nasa/sample_app#198 - nasa/sample_app#201 - nasa/sample_app#205 - nasa/sample_app#208 - nasa/sample_app#209 *ci_lab* - nasa/ci_lab#148 *sch_lab* - nasa/sch_lab#151 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 30, 2023
*Combines:* sample_app v1.3.0-rc4+dev56 ci_lab v2.5.0-rc4+dev51 sch_lab v2.5.0-rc4+dev61 **Includes:** *sample_app* - nasa/sample_app#189 - nasa/sample_app#195 - nasa/sample_app#198 - nasa/sample_app#201 - nasa/sample_app#205 - nasa/sample_app#208 - nasa/sample_app#209 *ci_lab* - nasa/ci_lab#148 *sch_lab* - nasa/sch_lab#151 Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Testing performed
GitHub CI actions all passing successfully.
Local testing confirms 100% of cFS suite tests passing (incl. Sample App tests) and coverage unaffected.
Prior to changes:
After changes:
Expected behavior changes
No change to behavior.
The Sample App now more closely matches the recommended structure/style for cFS apps.
System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt