Avoid compile warnings due to printf format #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using printf-style format conversions one must generally cast the argument to the intended type, as it does not happen implicitly with variable-argument functions. In particular the existing code worked on the default (native) build but generated warnings when building on RTEMS for a 32-bit x86 target.
skliper
approved these changes
Dec 11, 2019
|
CCB 20191218 - Reviewed and approved for IC |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #30
When using printf-style format conversions one must generally cast the argument to the intended type, as it does not happen implicitly with variable-argument functions.
In particular the existing code worked on the default (native) build but generated warnings when building on RTEMS for a 32-bit x86 target.
Testing performed
Build for i686 RTEMS and x86-64 (native) and ensure no warnings on either platform
Expected behavior changes
None.
System(s) tested on:
Ubuntu 18.04 LTS 64-bit build machine, and i686-rtems4.11 cross target.
Contributor Info
Joseph Hickey, Vantage Systems, Inc.
Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted