Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #141, Adds format changes in to_lab_app.c #142

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Conversation

chillfig
Copy link
Contributor

@chillfig chillfig commented Dec 8, 2022

Describe the contribution

Testing performed
clang

Expected behavior changes
Passing format check

System(s) tested on

  • Ubuntu 18.04

Additional context
N/A

Third party code
N/A

Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, Vantage

@chillfig chillfig added continuous-integration CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Dec 8, 2022
@dzbaker dzbaker added CCB:Approved Indicates approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Dec 8, 2022
dzbaker added a commit to nasa/cFS that referenced this pull request Dec 20, 2022
*Combines:*

cFE v7.0.0-rc4+dev242
t0_lab v2.5.0-rc4+dev35

**Includes:**

*cFE*
- nasa/cFE#2231
- nasa/cFE#2229
- nasa/cFE#2192

*to_lab*
- nasa/to_lab#142

Co-authored by: Daniel Knutsen <dmknutsen@users.noreply.github.com>
Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored by: Avi Weiss: <thnkslprpt@users.noreply.github.com>
@dzbaker dzbaker merged commit 911789b into nasa:main Dec 20, 2022
dzbaker added a commit to nasa/cFS that referenced this pull request Dec 20, 2022
*Combines:*

cFE v7.0.0-rc4+dev242
to_lab v2.5.0-rc4+dev35

**Includes:**

*cFE*
- nasa/cFE#2231
- nasa/cFE#2229
- nasa/cFE#2192

*to_lab*
- nasa/to_lab#142

Co-authored by: Daniel Knutsen <dmknutsen@users.noreply.github.com>
Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored by: Avi Weiss: <thnkslprpt@users.noreply.github.com>
@jphickey
Copy link
Contributor

Something strange got modified by this change, it seems to have removed a return statement that used to be here:

return status;

This seems like a mistake....

jphickey added a commit to jphickey/to_lab that referenced this pull request Jan 19, 2023
Corrects errors from PR 142 where return and break appear to have been
inadvertently removed
jphickey added a commit to jphickey/to_lab that referenced this pull request Jan 19, 2023
Corrects errors from PR 142 where return and break appear to have been
inadvertently removed
dzbaker added a commit that referenced this pull request Jan 19, 2023
HotFix #142, correct errors with whitespace application
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing format check in to_lab_app.c
3 participants