Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #63, Use MSG APIs #64

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Nov 4, 2020

Describe the contribution
Replaces deprecated SB API's with MSG
Fix #63

Testing performed
Built and ran, enabled telemetry, checked noops

Expected behavior changes
None

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
nasa/cFE#777

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Nov 4, 2020
@astrogeco
Copy link
Contributor

CCB 2020-11-04

  • By changing where the message is used then the message tlm header as a the sb header. Might affect the expected padding.
    • Should be ok on board. Might require explicit ground padding

@astrogeco astrogeco added CCB-20201104 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Nov 4, 2020
@astrogeco astrogeco changed the base branch from main to integration-candidate November 10, 2020 18:40
@astrogeco astrogeco merged commit 1dac87e into nasa:integration-candidate Nov 10, 2020
astrogeco added a commit to nasa/cFS that referenced this pull request Nov 10, 2020
astrogeco added a commit to nasa/cFS that referenced this pull request Nov 16, 2020
* Add nasa/cFE#984

* Add nasa/cFE#980

* Add nasa/cFE#867

* Add nasa/osal#638 and update cfe due to rebase

* Add nasa/cFE#987

* Add nasa/to_lab#64 and nasa/sample_app#104

* Add nasa/osal#643

* Add nasa/cFE#1000

* Add nasa/ci_lab#58

* Add doxygen fixes for nasa/osal#643

* Add nasa/cFE#1013

* Add nasa/cFE#1011

* Add nasa/ci_lab#61

* Add nasa/sample_app#109

* Bump versions and point to submodules main

Co-authored-by: Joseph Hickey <joseph.p.hickey@nasa.gov>
@skliper skliper deleted the fix63-use-msg-apis branch February 1, 2021 20:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependencies on deprecated SB APIs
2 participants