Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

This needs array key to be a constant and not a string #78

Closed
nategood opened this issue May 21, 2013 · 2 comments
Closed

This needs array key to be a constant and not a string #78

nategood opened this issue May 21, 2013 · 2 comments
Labels

Comments

@nategood
Copy link
Owner

https://github.com/nategood/httpful/blob/master/src/Httpful/Request.php#L149

@somescout
Copy link

https://github.com/nategood/httpful/blob/master/src/Httpful/Request.php#L149
I may be wrong, but should not this line have '==' instead of '='?

$this->additional_curl_opts['CURLOPT_HTTPAUTH'] = CURLAUTH_DIGEST;

@nategood
Copy link
Owner Author

Yep. That's already a pull request. However it breaks the build unless this
is also fixed.
On May 22, 2013 3:47 AM, "somescout" notifications@github.com wrote:

I may be wrong, but should not this line have '==' instead of '='?

$this->additional_curl_opts['CURLOPT_HTTPAUTH'] = CURLAUTH_DIGEST;


Reply to this email directly or view it on GitHubhttps://github.com//issues/78#issuecomment-18262331
.

nategood pushed a commit that referenced this issue May 22, 2013
 - FEATURE [I #77](#77) Convenience method for setting a timeout (seconds) `$req->timeoutIn(10);`
 - FIX [I #75](#75) [I #78](#78) Bug with checking if digest auth is being used.
 - Minor README tweaks to update version and reference new download url
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants