This repository has been archived by the owner on Nov 4, 2022. It is now read-only.
Bump version to 0.0.4 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
reviewed
May 19, 2022
Comment on lines
+4
to
+11
| def get_version() -> str: | ||
| rel_path = "modelcards/__init__.py" | ||
| with open(rel_path, "r") as fp: | ||
| for line in fp.read().splitlines(): | ||
| if line.startswith("__version__"): | ||
| delim = '"' if '"' in line else "'" | ||
| return line.split(delim)[1] | ||
| raise RuntimeError("Unable to find version string.") |
There was a problem hiding this comment.
FYI, this is how I handle getting version during the setup, it's handled in the __init__ file: https://github.com/skops-dev/skops/blob/main/skops/__init__.py
and then during the setup you do:
https://github.com/skops-dev/skops/blob/main/setup.py#L10-L17
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping version in preparation for releasing 0.0.4. Also added
get_version()insetup.pyand ignoredflake8errors inmodelcards/__init__.py.