This repository has been archived by the owner on Nov 4, 2022. It is now read-only.
Add Push To Hub Tests #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
reviewed
Jun 22, 2022
Comment on lines
+20
to
+21
| yield repo_id | ||
| delete_repo(repo_id, token=HF_TOKEN) |
There was a problem hiding this comment.
you'd need a context manager for this to work, otherwise if while working on the repo_id there's an exception, the repo is never deleted (I think).
There was a problem hiding this comment.
I think its safe? Since it's only making "one state change" in the fixture: Ref: https://docs.pytest.org/en/7.1.x/how-to/fixtures.html#safe-fixture-structure
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test user token/username and uses them to test
push_to_hub.