Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix c++ and windows compatibility #56

Merged
merged 3 commits into from
Feb 10, 2024

Conversation

sshsphere
Copy link
Contributor

Add explicit casts and use Sleep function instead of nanosleep on windows

@sshsphere sshsphere marked this pull request as ready for review February 9, 2024 18:50
@nathhB
Copy link
Owner

nathhB commented Feb 10, 2024

It fails to compile:

In file included from /Users/nathb/Dev/GameDev/nbnet/soak/client.c:37:
/Users/nathb/Dev/GameDev/nbnet/soak/../net_drivers/webrtc_c.h:325:65: error: expected expression
    struct json_object_element_s *curr = (json_object_element_s*)object->start;
                                                                ^
/Users/nathb/Dev/GameDev/nbnet/soak/../net_drivers/webrtc_c.h:325:43: error: use of undeclared identifier 'json_object_element_s'
    struct json_object_element_s *curr = (json_object_element_s*)object->start;
                                          ^
/Users/nathb/Dev/GameDev/nbnet/soak/../net_drivers/webrtc_c.h:422:31: error: unexpected type name 'rtcConfiguration': expected expression
    rtcConfiguration rtcCfg = rtcConfiguration{
                              ^
/Users/nathb/Dev/GameDev/nbnet/soak/../net_drivers/webrtc_c.h:461:41: error: unexpected type name 'rtcDataChannelInit': expected expression
    rtcDataChannelInit rtcDataChannel = rtcDataChannelInit{
                                        ^
4 errors generated.
make[2]: *** [CMakeFiles/client.dir/build.make:76: CMakeFiles/client.dir/client.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:85: CMakeFiles/client.dir/all] Error 2
make: *** [Makefile:91: all] Error 2

@nathhB nathhB merged commit 36088bc into nathhB:master Feb 10, 2024
18 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants