Remove warning from terraform plan (#551)

Many warnings form tdr-terraform-modules/s3 that has now been updated. Use latest version
nationalarchives · Jan 8, 2025 · fc8e4cd · fc8e4cd
1 parent 53f4007
commit fc8e4cd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/root.tf b/root.tf
@@ -144,7 +144,10 @@ module "upload_file_cloudfront_dirty_s3" {
   cloudfront_oai               = module.cloudfront_upload.cloudfront_oai_iam_arn
   cloudfront_distribution_arns = [module.cloudfront_upload.cloudfront_arn]
 }
-
+# This is the only module that uses the canonical user grants in the tdr-terraform-modules/s3 module
+# Grants are no longer the recommended way to grant access to a bucket. The s3 module will use the
+# canonical user grants id in the bucket policy with permissions equivalent to 'FULL_CONTROL'
+# tdr-terraform-modules/s3 module will be deprecated.
 module "upload_file_cloudfront_logs" {
   source      = "./tdr-terraform-modules/s3"
   project     = var.project

diff --git a/tdr-terraform-modules b/tdr-terraform-modules
+80 −57		s3/main.tf
+1 −1		s3/templates/cloudtrail.json.tpl
+21 −2		s3/templates/secure_transport.json.tpl
+2 −1		s3/variables.tf
+1 −1		vpc/main.tf