Add missing type attribute on accordion buttons

nationalarchives · Jan 21, 2025 · af95eec · af95eec
1 parent 18fc6e3
commit af95eec
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Deprecated
 ### Removed
 ### Fixed
+
+- Added missing `type` attribute on accordion buttons
+
 ### Security
 
 ## [0.8.0](https://github.com/nationalarchives/tna-frontend/compare/v0.7.2...v0.8.0) - 2025-01-15

diff --git a/src/nationalarchives/components/accordion/accordion.mjs b/src/nationalarchives/components/accordion/accordion.mjs
@@ -34,6 +34,7 @@ export class Accordion {
 
     const $headingButton = document.createElement("button");
     $headingButton.classList.add("tna-accordion__summary");
+    $headingButton.setAttribute("type", "button");
     $headingButton.setAttribute("aria-controls", $content.id);
     $heading.parentNode.insertBefore($headingButton, $heading.nextSibling);
     $headingButton.appendChild($heading);