Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix race condition between server shutdown and consumer info #6356

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Fix race condition between server shutdown and consumer info #6356

merged 2 commits into from
Jan 9, 2025

Conversation

neilalexander
Copy link
Member

Signed-off-by: Neil Twigg neil@nats.io

@neilalexander
Fix race condition between server shutdown and consumer info
f3aedf5 
Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander requested a review from a team as a code owner January 9, 2025 16:25
wallyqs
wallyqs approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander
Fix race in TestJetStreamClusterGhostEphemeralsAfterRestart
7e92926 
Signed-off-by: Neil Twigg <neil@nats.io>
wallyqs
wallyqs approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 733315a into main Jan 9, 2025
5 checks passed
@derekcollison derekcollison deleted the neil/jscirace branch January 9, 2025 17:13
@wallyqs wallyqs mentioned this pull request Jan 9, 2025
Merged
wallyqs added a commit that referenced this pull request Jan 9, 2025
@wallyqs
Cherry-picks for 2.10.25-RC.1 (#6345)
339d1b3 
#### Dependencies
- #6323
- #6324

####  Leafnode
- #6291

#### JetStream
- #6226
- #6235
- #6277
- #6279
- #6283
- #6289
- #6316
- #6317
- #6325
- #6326
- #6335
- #6338
- #6341
- #6344
- #6150
- #6351
- #6355

#### Tests
- #6278
- #6297
- #6300
- #6343
- #6329
- #6330
- #6331
- #6332
- #6334
- #6356
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neilalexander @wallyqs @derekcollison