Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[FIXED] Stream/consumer limit reached edge conditions #6477

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

MauriceVanVeen
Copy link
Member

Using MaxStreams and MaxConsumers you can limit the amount of streams, and the amount of consumers on a specific stream.

There were some edge conditions where stream/consumer creates would fail with a "limit reached" error which have been fixed in this PR:

  • non-clustered create of a stream that already exists when at limit
  • clustered create of a stream that already exists when at limit
  • clustered create of a consumer that already exists when at limit

In above cases the accounting would think an additional stream/consumer would be added which would exceed the limit, even though this was not the case and the request should have been successful.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner February 8, 2025 22:48
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit d901f5d into main Feb 9, 2025
5 checks passed
@derekcollison derekcollison deleted the maurice/stream-consumer-limit branch February 9, 2025 16:16
neilalexander added a commit that referenced this pull request Feb 10, 2025
Includes the following:

- #6465
- #6464
- #6469
- #6471
- #6472
- #6474
- #6477
- #6480
- #6487
- #6488

Signed-off-by: Neil Twigg <neil@nats.io>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants