[FIXED] Consumer skips some messages (WQ / Interest Streams) #6526
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
maurice/consumer-skips-messages
branch
from
7bdd728 to
44c077c
Compare
wallyqs
changed the title
neilalexander
added a commit
that referenced
this pull request
Feb 21, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consumers could occasionally skip messages given specific message removal patterns. This was most prevalent for WorkQueue and Interest-based streams.
The issue lies in both
ss.Firstandss.Lastbeing lazy and needing to be recalculated once they are needed.ss.Lastwas not recalculated before, but it is since #6235 ensuring the subject state remains correct.However, if
ss.Lastwas overwritten after a new message was ingested into the stream, thess.lastNeedsUpdateflag was not updated. Which resulted inss.Lastbeing recalculated to a lower value, skipping over the message with the sequence that was previouslyss.Last.Signed-off-by: Maurice van Veen github@mauricevanveen.com